Re: Better auth errors from libpq

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Better auth errors from libpq
Date: 2008-09-12 05:39:39
Message-ID: 48CA009B.4050708@commandprompt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Fetter wrote:
> On Thu, Sep 11, 2008 at 11:28:36PM -0400, Tom Lane wrote:
>> Joshua Drake <jd(at)commandprompt(dot)com> writes:
>>> I think something like:
>>> psql: FATAL: Ident authentication failed for user "root"
>>> HINT: http://www.postgresql.org/docs/8.3/static/client-authentication.html
>>> Would be nice.
>> Do you really think that's helpful in the typical case where someone
>> fat-fingered their password?
>>
>> I'm not averse to hint messages that are actually helpful, ie,
>> reasonably connected to the *specific* failure situation. The problem
>> I've got with David's proposal is that it provides a one-size-fits-all
>> hint for every possible auth failure. One size does not fit all here.
>
> Here's a few different sizes: one for each auth method.

The only thing I would say here is that you point the URL to current
which will be wrong in one release. Perhaps something that pulls the
pgversion macro?

Sincerely,

Joshua D. Drake

>
> Cheers,
> David.
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2008-09-12 06:30:33 Re: Better auth errors from libpq
Previous Message Joshua D. Drake 2008-09-12 05:38:31 Re: Better auth errors from libpq