Re: [PATCH] Cleanup of GUC units code

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Hannu Krosing <hannu(at)krosing(dot)net>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Gregory Stark <stark(at)enterprisedb(dot)com>, Marko Kreen <markokr(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Cleanup of GUC units code
Date: 2008-09-03 14:52:38
Message-ID: 48BEA4B6.50705@commandprompt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hannu Krosing wrote:
> On Tue, 2008-09-02 at 16:50 +0300, Peter Eisentraut wrote:
>> Gregory Stark wrote:
>>> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:

> Are you really afraid that someone would want to use mb to mean
> millibits ?
>
> As SQL is generally case insensitive, it is quite surprising to most
> people that GUC units are not.

We have had this discussion before, I even submitted a patch to make
them case insensitive. In retrospect I was wrong to submit that patch.
SQL may be case insensitive but units are not. MB != Mb != mb , I don't
think we should encourage in any way for users to do the wrong thing.

Sincerely,

Joshua D. Drake

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-09-03 15:05:19 Re: Function call order dependency
Previous Message Andrew Chernow 2008-09-03 14:09:36 Re: libpq object hooks (libpq events)