From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Re: [COMMITTERS] pgsql: Remove all traces that suggest that a non-Bison yacc might be |
Date: | 2008-08-29 16:47:15 |
Message-ID: | 48B82813.7000401@gmx.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera wrote:
> I'm finding that this patch is needed to make this build on VPATH:
I cannot reproduce any problem with a vpath build. Make sure you have
really cleaned the source tree from previous rounds. Some of the files
involved are symlinks, which might confuse make.
> Index: src/backend/parser/Makefile
> ===================================================================
> RCS file: /cvsroot/pgsql/src/backend/parser/Makefile,v
> retrieving revision 1.47
> diff -c -p -r1.47 Makefile
> *** src/backend/parser/Makefile 29 Aug 2008 13:02:32 -0000 1.47
> --- src/backend/parser/Makefile 29 Aug 2008 16:17:16 -0000
> *************** subdir = src/backend/parser
> *** 10,16 ****
> top_builddir = ../../..
> include $(top_builddir)/src/Makefile.global
>
> ! override CPPFLAGS := -I$(srcdir) $(CPPFLAGS)
>
> OBJS= analyze.o gram.o keywords.o parser.o parse_agg.o parse_clause.o \
> parse_expr.o parse_func.o parse_node.o parse_oper.o parse_relation.o \
> --- 10,16 ----
> top_builddir = ../../..
> include $(top_builddir)/src/Makefile.global
>
> ! override CPPFLAGS := -I$(srcdir)/.. $(CPPFLAGS)
>
> OBJS= analyze.o gram.o keywords.o parser.o parse_agg.o parse_clause.o \
> parse_expr.o parse_func.o parse_node.o parse_oper.o parse_relation.o \
This would create a reference to src/backend, but no .h file should ever
live there.
> The problem is that keywords.c is #including "parser/gram.h" but since
> we're doing a -I.../backend/parser then it doesn't find it.
>
> I don't understand why it was working previously.
I think the -I$(srcdir) is actually useless, and you are just
accidentally adapting it for your workaround.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-08-29 16:48:59 | Re: Re: [COMMITTERS] pgsql: Remove all traces that suggest that a non-Bison yacc might be |
Previous Message | Tom Lane | 2008-08-29 16:34:14 | pgsql: Suppress gcc warning about possibly-uninitialized variable. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-08-29 16:48:59 | Re: Re: [COMMITTERS] pgsql: Remove all traces that suggest that a non-Bison yacc might be |
Previous Message | Alvaro Herrera | 2008-08-29 16:44:13 | Re: Proposal: new border setting in psql |