Re: Re: [COMMITTERS] pgsql: Remove all traces that suggest that a non-Bison yacc might be

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Remove all traces that suggest that a non-Bison yacc might be
Date: 2008-08-29 16:48:59
Message-ID: 22813.1220028539@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> I cannot reproduce any problem with a vpath build. Make sure you have
> really cleaned the source tree from previous rounds. Some of the files
> involved are symlinks, which might confuse make.

"make maintainer-clean" before pulling this update would be a good idea,
else you're going to have junk laying about in your source tree.

> I think the -I$(srcdir) is actually useless, and you are just
> accidentally adapting it for your workaround.

Yeah, it should be finding the symlink in $builddir/src/include/parser.

If the -I isn't needed, shouldn't we get rid of it?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2008-08-29 17:00:42 Re: Re: [COMMITTERS] pgsql: Remove all traces that suggest that a non-Bison yacc might be
Previous Message Peter Eisentraut 2008-08-29 16:47:15 Re: Re: [COMMITTERS] pgsql: Remove all traces that suggest that a non-Bison yacc might be

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2008-08-29 17:00:42 Re: Re: [COMMITTERS] pgsql: Remove all traces that suggest that a non-Bison yacc might be
Previous Message Peter Eisentraut 2008-08-29 16:47:15 Re: Re: [COMMITTERS] pgsql: Remove all traces that suggest that a non-Bison yacc might be