Re: temporary statistics option at initdb time

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Decibel!" <decibel(at)decibel(dot)org>, Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, pgsql-hackers(at)postgresql(dot)org, Euler Taveira de Oliveira <euler(at)timbira(dot)com>
Subject: Re: temporary statistics option at initdb time
Date: 2008-08-25 15:33:35
Message-ID: 48B2D0CF.9010209@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Tom Lane wrote:
>>> I think this is introducing complication and race conditions to solve a
>>> problem that no one will really care about. Just let people change the
>>> filename at SIGHUP and document that doing that on-the-fly may cause
>>> stats queries to fail for a short interval.
>
>> Ok, I'll do it that way.
>
> BTW, it might be worth tweaking the stats collector to dump stats
> immediately after responding to SIGHUP, just to narrow this window
> as much as possible.

Pah, that is too obvious :-)
Yeah, should've thought of that, will make that happen.

> [ squint... ] Actually, it looks like the stats collector SIG_IGNores
> SIGHUP? That can't be right (any more) can it?

It did, until after my patch that was applied a couple of minutes ago.
After the patch, it cares about SIGHUP.

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-08-25 15:33:57 Re: temporary statistics option at initdb time
Previous Message Tom Lane 2008-08-25 15:29:50 Re: temporary statistics option at initdb time