Re: Update: mac.c update, patch now on ftp

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Larry Rosenman <ler(at)lerctr(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Update: mac.c update, patch now on ftp
Date: 2000-07-17 21:46:01
Message-ID: 4895.963870361@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> In looking at this patch, it changes mac.c from:
>>
>> 8513 mac.c
>> 184323 mac.c.new

Yipes.

>> This seems like a major size increase. Is it worth it to get
>> card manufacturers?

> Given that our list is old, and the new list is large, does anyone
> really want this feature. It allows the lookup of an ethernet card
> manufacturer based on the ethernet MAC address.

Seems like hardwiring the lookup table in the server code is
fundamentally wrongheaded anyway. It should have been designed as
(wait for it...) a database table lookup.

I'd suggest maybe this feature should be offered as a contrib item
containing a database table dump and a simple lookup function
coded in SQL. Lots easier to maintain, and it doesn't bloat the
backend for people who don't need it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Swan 2000-07-17 21:56:28 Re: TUPLE SIZE HELP
Previous Message Tom Lane 2000-07-17 21:42:12 Re: psql eating backslashes