| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Sushant Sinha <sushant354(at)gmail(dot)com> |
| Cc: | Pierre-Yves Strub <pierre(dot)yves(dot)strub(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [GENERAL] Fragments in tsearch2 headline |
| Date: | 2008-07-15 09:29:54 |
| Message-ID: | 487C6E12.3030906@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
> Attached a new patch that:
>
> 1. fixes previous bug
> 2. better handles the case when cover size is greater than the MaxWords.
Looks good, I'll make some tests with real-world application.
> I have not yet added the regression tests. The regression test suite
> seemed to be only ensuring that the function works. How many tests
> should I be adding? Is there any other place that I need to add
> different test cases for the function?
Just add 3-5 selects to src/test/regress/sql/tsearch.sql with checking basic
functionality and corner cases like
- there is no covers in text
- Cover(s) is too big
- and so on
Add some words in documentation too, pls.
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Peck | 2008-07-15 09:59:47 | Re: Multithreaded queue in PgSQL |
| Previous Message | Ragnar | 2008-07-15 09:28:50 | Re: optimizer ignoring primary key and doing sequence scan |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xiao Meng | 2008-07-15 09:56:19 | Is there anyway to create a TupleDesc with uint32 attribute easily? |
| Previous Message | Simon Riggs | 2008-07-15 08:31:29 | Re: [PATCHES] WIP: executor_hook for pg_stat_statements |