Re: idea: storing view source in system catalogs

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To:
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: idea: storing view source in system catalogs
Date: 2008-05-21 08:40:21
Message-ID: 4833DFF5.7080500@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Florian Pflug wrote:
>
> But maybe you could store the whitespace appearing before (or after?)
> a token in the parse tree that is stored for a view. That might not
> allow reconstructing the *precise* statement, but at least the
> reconstructed statement would preserve newlines and indention - which
> probably is the whole reason for wanting to store the original
> statement in the first place, no? I

Not the whole reason. To get a view definition that is more readable,
the pretty_bool option of pg_get_viewdef already does some newline and
indent formatting. Not the initial formatting, but Good Enough (TM), I
believe.

What's really lost is any comment that might have existed in the initial
source. I previously had the idea to invent comment nodes, but never
came to implement them.

Regards,
Andreas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Luke Lonergan 2008-05-21 11:52:28 Re: Posible planner improvement?
Previous Message Stephen Denne 2008-05-21 03:44:49 Re: triggers on prepare, commit, rollback... ?