Re: Link requirements creep

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Marko Kreen <markokr(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Link requirements creep
Date: 2008-05-20 01:04:19
Message-ID: 48322393.9030403@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> I wrote:
>
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>
>>> It broke my FC6 box :-(
>>>
>
>
>> Yeah, I saw. I'm inclined to wait a day to get a handle on the scope
>> of the problem before trying to choose an appropriate fix.
>>
>
> So the returns are in, and buildfarm says: this is only broken on
> Red Hat-based systems. How embarrassing :-(
>
> It's evidently fixed in Fedora 7 and up, which means that only EOL'd
> Fedora distributions are affected, but since RHEL 5 is affected I'm
> still on the hook to fix it.
>
> What I'm inclined to do is move the test for -Wl,--as-needed down till
> after we've determined the readline dependent-libraries situation, and
> then enable it only if we can still link readline with it on. So a
> system with broken readline won't get the benefit. But the available
> evidence says that there are too few such systems to justify a more
> complicated solution.
>
>
>

Works for me. I don't think we need anything heroic either.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2008-05-20 01:07:35 Re: triggers on prepare, commit, rollback... ?
Previous Message Tom Lane 2008-05-20 00:48:29 Re: Link requirements creep