Re: ignore $PostgreSQL lines in regression tests?

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ignore $PostgreSQL lines in regression tests?
Date: 2008-05-18 18:45:26
Message-ID: 48307946.6000800@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> Recently while adding $PostgreSQL markers to a bunch of .c and .h files
>> I ran into trouble with the ecpg regression tests and had to revert the
>> change for a handful of files. However, it occurred to me that we could
>> have pg_regress tell diff to ignore such lines, by passing it the
>> arguments "-I '\$PostgreSQL:' ", which would tell it to ignore
>> additions or deletions of lines matching that regex.
>>
>
>
>> Would this be a good thing to do?
>>
>
> I'm inclined to think not. It's easy to think of scenarios where such
> a switch would mask errors.
>
>
>

OK.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2008-05-18 18:47:37 Re: WITH RECURSIVE patch V0.1
Previous Message Tom Lane 2008-05-18 17:46:01 Re: ignore $PostgreSQL lines in regression tests?