Re: ignore $PostgreSQL lines in regression tests?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ignore $PostgreSQL lines in regression tests?
Date: 2008-05-18 17:46:01
Message-ID: 10482.1211132761@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Recently while adding $PostgreSQL markers to a bunch of .c and .h files
> I ran into trouble with the ecpg regression tests and had to revert the
> change for a handful of files. However, it occurred to me that we could
> have pg_regress tell diff to ignore such lines, by passing it the
> arguments "-I '\$PostgreSQL:' ", which would tell it to ignore
> additions or deletions of lines matching that regex.

> Would this be a good thing to do?

I'm inclined to think not. It's easy to think of scenarios where such
a switch would mask errors.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2008-05-18 18:45:26 Re: ignore $PostgreSQL lines in regression tests?
Previous Message Andrew Dunstan 2008-05-18 17:42:47 ignore $PostgreSQL lines in regression tests?