Re: odd output in restore mode

Simon Riggs wrote:
> On Mon, 2008-05-12 at 18:58 -0400, Andrew Dunstan wrote:
>
>
>> No, it had to do with pg_standby waiting for a WAL file that had already
>> gone, somehow. I will try to reproduce it when I get a spare moment.
>>
>
> Sounds like the bug I just fixed.
>

Yes, so I see. I didn't have that fix, so I'll test again with the patch.
>
>
>>> There is an outstanding Windows issue with pg_standby that your help
>>> would be appreciated with, shown on latest commitfest page. It's a
>>> Windows issue and I don't maintain a Windows dev environment.
>>>
>
>
>> The patch has been rejected for now, according to the Commitfest page.
>> Not sure what you want my help on.
>>
>
> Well, the patch was rejected long ago, not sure why its in this
> commitfest. But its an open issue on the Windows port.
>
>

Surely the right fix is to use the recently implemented
pgwin32_safestat() (if we aren't already - I suspect we probably are)
and remove the kluge in pg_standby.c.

cheers

andrew