MSVC build broken

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: MSVC build broken
Date: 2008-05-09 02:35:01
Message-ID: 4823B855.7040801@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


The recent xml2 build changes have broken MSVC builds.

The problem is this fragment (that appears twice) from
src/tools/msvc/Mkvcbuild.pm:

foreach my $o (split /\s+/, $1)
{
$o =~ s/\.o$/.c/;
$proj->AddFile('contrib\\' . $n . '\\' . $o);
}

which gets applied to this line: (after "OBJS = " has been stripped):

OBJS = $(if $(filter -lxslt, $(LIBS)), xpath.o xslt_proc.o, xpath.o)

Our logic above is far too rough for such lines. I'll try to come up
with something more robust tomorrow.

cheers

andrew

Browse pgsql-hackers by date

  From Date Subject
Next Message Guillaume Smet 2008-05-09 02:37:26 Re: [NOVICE] encoding problems
Previous Message Gregory Stark 2008-05-08 21:28:58 Re: Posting to hackers and patches lists