Re: CopyReadLineText optimization

Andrew Dunstan wrote:
>
>
> Heikki Linnakangas wrote:
>> Andrew Dunstan wrote:
>>> I'm still a bit worried about applying it unless it gets some
>>> adaptive behaviour or something so that we don't cause any serious
>>> performance regressions in some cases.
>>
>> I'll try to come up with something. At the most conservative end, we
>> could fall back to the current method on the first escape, quote or
>> backslash character.
>>
>>> Also, could we perhaps benefit from inlining some calls, or is your
>>> compiler doing that anyway?
>>
>> gcc does inline all static functions that are only called from one
>> site, and small functions, using some heuristic. I don't think more
>> aggressive inlining would help.
>>
>
> Another question that occurred to me - did you try using strpbrk() to
> look for the next interesting character rather than your homegrown
> searcher gadget? If so, how did that perform?

I haven't tried that. There's a small difference: strpbrk stops at '\0'.
But come to think of it, I guess it doesn't matter. Will test...

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com