From: | "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> |
---|---|
To: | "Andrew Dunstan" <andrew(at)dunslane(dot)net> |
Cc: | <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: CopyReadLineText optimization |
Date: | 2008-03-06 19:44:31 |
Message-ID: | 47D0499F.301@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Andrew Dunstan wrote:
> I'm still a bit worried about applying it unless it gets some adaptive
> behaviour or something so that we don't cause any serious performance
> regressions in some cases.
I'll try to come up with something. At the most conservative end, we
could fall back to the current method on the first escape, quote or
backslash character.
> Also, could we perhaps benefit from inlining
> some calls, or is your compiler doing that anyway?
gcc does inline all static functions that are only called from one site,
and small functions, using some heuristic. I don't think more
aggressive inlining would help.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2008-03-06 19:56:32 | Re: CopyReadLineText optimization |
Previous Message | Heikki Linnakangas | 2008-03-06 19:38:36 | Re: CopyReadLineText optimization |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2008-03-06 19:56:32 | Re: CopyReadLineText optimization |
Previous Message | Heikki Linnakangas | 2008-03-06 19:38:36 | Re: CopyReadLineText optimization |