Re: [HACKERS] possible bug windows setup

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Gevik Babakhani <pgdev(at)xs4all(dot)nl>, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] possible bug windows setup
Date: 2008-02-07 11:12:17
Message-ID: 47AAE791.1060207@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Magnus Hagander wrote:
> On Wed, Feb 06, 2008 at 02:59:31PM +0100, Gevik Babakhani wrote:
>
>> I might be very wrong, but when I try to install 8.3 on Windows with NLS
>> options selected, no share/locale files are installed. could someone please
>> test or confirm this?
>>
>
> Yes, it's broken. It seems the change in Install.pm rev 1.20 to use
> File::Find instead of external dir broke this, and was never tested at all
> :-(
>
> I know I build without NLS enabled, and it seems so does everybody else who
> regularly builds the msvc stuff.
>
> There is no testing at all of the NLS stuff in the regression tests.
> Perhaps it would be a good idea to do that? Could be somethign as simple as
> launching psql in a way tha tgenerates a syntax error and make sure i
> matches a proper translation?
>
>
> (and yes, I'm working on a patch for the actual issue)
>
>
>

Oops, My bad!

I think if we just change the forward slashes to backslashes at the top[
of that loop it should work, but haven't had time to test.

cheers

andrew

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Magnus Hagander 2008-02-07 11:16:09 Re: [HACKERS] possible bug windows setup
Previous Message Alvaro Herrera 2008-02-07 10:59:24 Re: BUG #3938: Row-wise comparison fails

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2008-02-07 11:16:09 Re: [HACKERS] possible bug windows setup
Previous Message Manolo _ 2008-02-07 11:04:52 Re: 2WRS [WIP]