Re: Recent pg_regress changes break testing under SELinux

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Recent pg_regress changes break testing under SELinux
Date: 2008-01-19 15:03:36
Message-ID: 47921148.5030606@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Yeah, agreed. The original idea was to have a shortcut created by the
>> installer to do that for you.
>> ...
>> Well, there is a way to run it from the msvc build. The idea was to be
>> able to run after a binary install. Granted it doesn't make that much
>> sense, but it was mostly a "customer feel good" thing. But there's
>> nothing preventing that from being done from a .BAT file instead of a
>> direct shortcut.
>
> Well, I suppose anything along this line is more code churn than we
> should engage in post-RC2. What I propose for now is that we just
> "#ifdef WIN32" the directory deletion/remaking in pg_regress.c, with
> a suitable comment, and then we can revisit the issue in 8.4 or later.

Works for me.

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonah H. Harris 2008-01-19 15:22:13 Re: sun to buy mysql
Previous Message ohp 2008-01-19 15:01:32 sun to buy mysql