From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: odd convert_from bug |
Date: | 2008-01-10 00:53:41 |
Message-ID: | 47856C95.2000007@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andrew Dunstan wrote:
>
>
> Tom Lane wrote:
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>
>>> The case below has just been reported to me. It sure looks odd. I'm
>>> looking into it but any ideas would be welcome. The problem only
>>> occurs if we are updating more than one row.
>>>
>>
>> Pfree'ing something you didn't palloc is bad news...
>>
>
> Ah, yes, thanks, looks like I was a little too eager on the C&P. I see
> you have fixed it.
>
>
BTW, if calling pfree() at all here is actually a bug, then we should
probably fix it in the back branches. It looks more to me like the
problem was that pg_convert_from was calling pfree() with the wrong
argument - src_encoding_name instead of dest_encoding_name. But maybe
the pfree in the back branches is unnecessary but harmless.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Gavin Sherry | 2008-01-10 01:22:39 | Re: Dynamic Partitioning using Segment Visibility Maps |
Previous Message | Andrew Dunstan | 2008-01-09 23:58:46 | Re: odd convert_from bug |