Re: Proposed patch to disallow password=foo in database name parameter

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Proposed patch to disallow password=foo in database name parameter
Date: 2007-12-11 03:25:53
Message-ID: 475E0341.7080300@commandprompt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> "Joshua D. Drake" <jd(at)commandprompt(dot)com> writes:
>> Tom Lane wrote:
>>> As of PG 8.3, libpq allows a conninfo string to be passed in via the
>>> dbName parameter of PQsetdbLogin.
>
>> I didn't even know we could do that. I always use the shell variable
>> option instead. Does anyone actually use the facility?
>
> Well, not yet, because it's new in 8.3 ...

Yeah, let's not do that. Like you said, "While we cannot absolutely
prevent client apps from doing stupid things, it seems like it might be
a good idea to prevent passwords from being passed in through dbName. "

To me... this is something that if we allow, people will use it, and we
will end up removing it, realizing it is a bad idea. There are plenty of
other ways to pass the password in a more sane way.

Sincerely,

Joshua D. Drake

>
> regards, tom lane
>

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2007-12-11 03:33:43 Re: Proposed patch to disallow password=foo in database name parameter
Previous Message Stephen Frost 2007-12-11 03:15:48 Re: Proposed patch to disallow password=foo in database name parameter