Re: pgsql: Add compat file for dynamically loading the functions that MinGW

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add compat file for dynamically loading the functions that MinGW
Date: 2007-10-29 14:04:29
Message-ID: 4725E86D.2010802@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> mha(at)postgresql(dot)org (Magnus Hagander) writes:
>> Add compat file for dynamically loading the functions that MinGW is missing
>> the imports for. Add RegisterWaitForSingleObject() to the list of such
>> functions, which should take care of the current buildfarm breakage.
>
> Trivial stylistic complaint: shouldn't the _RegisterWaitForSingleObject
> variable be declared static? IMHO variables (and functions) should
> always be static unless there is an explicit intent to access them from
> other modules.

Yup, it certainly should. Fixing. Thanks.

//Magnus

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2007-10-29 14:04:42 pgsql: Make variable static, per Tom.
Previous Message Tom Lane 2007-10-29 13:54:04 Re: pgsql: Add compat file for dynamically loading the functions that MinGW