| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Dave Page <dpage(at)postgresql(dot)org>, Trevor Talbot <quension(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: 8.2.3: Server crashes on Windows using Eclipse/Junit |
| Date: | 2007-10-26 21:30:54 |
| Message-ID: | 47225C8E.3090202@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Attached is an updated version of the patch, currently being tested by
>> both me and Dave. If it passes our tests, I'll apply this so it gets
>> included for broader testing in beta2.
>
> One question: what's this about?
>
>> + #define _WIN32_WINNT 0x0500
>
> This looks like it might be tightening our assumptions about which
> Windows flavors we can run on. I'm not necessarily against that,
> but it should be publicly discussed if it's happening.
It enables Windows 2000-specific headers. We already require Windows
2000 to run, so it doesn't restrict us anymore than we already are. It
just exposes those parts of the header files.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Erik Jones | 2007-10-26 21:31:51 | Re: WAL archiving idle database |
| Previous Message | Tom Lane | 2007-10-26 21:30:26 | Re: 8.2.3: Server crashes on Windows using Eclipse/Junit |