| From: | Dave Page <dpage(at)postgresql(dot)org> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: OpenSSL Applink |
| Date: | 2007-10-01 14:21:30 |
| Message-ID: | 4701026A.5070200@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Magnus Hagander wrote:
> Yes, that was the problem. Attached patch fixes the problem for me on
> Windows and Linux using the error mark functionality. It seems a lot
> cleaner than the other option.
>
> Dave - can you test this one? Assuming that works, I'll go ahead and apply
> it.
Yep, looks good here. Thanks.
> I also think we have the same problem in the current code, just not for
> fopen(). We trap fopen() without anything happening inside OpenSSL, but if
> we get an error in the OpenSSL functions we call, something similar would
> likely happen.
>
> Should we backpatch all the stuff, or just the error push/pop thing?
All of it. Anyone building just libpq/psql using the old MSVC makefiles
will probably see the applink problem if they try to use client certs.
/D
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2007-10-01 14:32:11 | Re: 64bit compile linker problem of win32.mak. |
| Previous Message | Magnus Hagander | 2007-10-01 13:34:01 | Re: OpenSSL Applink |