Re: Lazy xid assignment V4

From: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, pgsql-patches(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Lazy xid assignment V4
Date: 2007-09-05 22:07:53
Message-ID: 46DF28B9.9000406@phlo.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan wrote:
> Florian G. Pflug wrote:
>>
>> So, in essence, you get the old pg_locks format back by doing
>> select l1.*, l2.transactionid as "transaction" from pg_locks l1,
>> pg_locks l2
>> where l1.vxid = l2.vxid and l2.locktype = 'transaction'
>> and l2.mode='exclusive' and l2.granted=true.
>>
>> Hm.. Maybe we should put that into the docs or into the release notes?
>>
> or make it a system view?
In that case we can just add "transaction" back to pg_locks, and save
the overhead of snapshotting the locking datastructures twice...

The reason against it was that we changed the semantics of the column -
if we just keep it there, people who use it might silently get wrong
results.

I think what we have now is fine for 8.3. Should we remove the
lock on the xid completely in 8.4, we'll have to revisit pg_locks
anway, since than the current views won't show a transactions xid at all.
But let's do that when 8.4 opens, and not now.

greetings, Florian Pflug

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-09-05 22:12:55 Re: Lazy xid assignment V4
Previous Message Andrew Dunstan 2007-09-05 21:59:06 Re: Lazy xid assignment V4

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-09-05 22:12:55 Re: Lazy xid assignment V4
Previous Message Bruce Momjian 2007-09-05 22:07:21 Re: HOT patch - version 15