Re: [HACKERS] pg_regress config

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] pg_regress config
Date: 2007-09-05 19:09:21
Message-ID: 46DEFEE1.30400@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Magnus Hagander wrote:
> Andrew Dunstan wrote:
>
>> I would like to add an argument to pg_regress that allows us to set some
>> config options for the temp install. Specifically right now I am
>> interested in setting the following:
>>
>> log_line_prefix = '[%c] '
>> log_statement = 'all'
>> log_connections = 'true'
>>
>> But I think it makes more sense to provide for a general option setting
>> mechanism, such as --extra_config=/path/to/some/file
>>
>> This would dovetail neatly with the recent suggestion that we might
>> provide for buildfarm members to run several config sets.
>>
>> Thoughts?
>>
>
> I think the file makes a lot more sense - would keep you from ending up
> with really horrible commandlines. Also, it would make it easier if you
> want to set up different configs manually (the buildfarm script can
> always manage).
>

OK, patch attached. I called the option 'temp-config' to go with
'temp-install'.

> What about the ability to pass options to initdb, while you're at it?
> Like changing the locale? (which will break the scripts, but it should
> only break them in predictable locations)
>
>
>

Sufficient unto the day is the evil thereof. We can handle that another
time.

What I will do however is add some ability to use this to the makefiles
and the vcregress script.

cheers

andrew

Attachment Content-Type Size
regressopt.patch text/x-patch 3.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-09-05 19:10:22 Re: loose ends in lazy-XID-assigment patch
Previous Message Tom Lane 2007-09-05 19:06:53 Re: loose ends in lazy-XID-assigment patch

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-09-05 19:32:00 Re: HOT patch - version 15
Previous Message Florian G. Pflug 2007-09-05 18:34:25 Re: Lazy xid assignment V4