Re: GUC failure on exception

From: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: GUC failure on exception
Date: 2010-01-21 17:42:58
Message-ID: 46DD1E63-F578-4B9D-814A-10CEE92FEC75@kineticode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Jan 19, 2010, at 9:26 PM, Andrew Dunstan wrote:

> The first thing I think we need to do is move the GUC processing code out of _PG_init() and into plperl_init_interp(), protected by a flag to make sure it's only called successfully once. I'm trying to work out a neat way to put the value back if there is an exception, but it's a bit ugly.

Will this solve the underlying bug in custom GUCs? I'm assuming there is such a bug. Won't this be an issue for other modules that have custom GUCs, potentially a security issue? The addition of new PL/Perl custom GUCs notwithstanding, it sure seems like a potential security vulnerability such as this should be addressed ASAP.

Who knows this stuff?

Best,

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Christensen 2010-01-21 17:46:47 Patch: regschema OID type
Previous Message David E. Wheeler 2010-01-21 17:35:41 Re: 8.5 vs. 9.0, Postgres vs. PostgreSQL