Skip site navigation (1) Skip section navigation (2)

Re: COPYable logs

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: COPYable logs
Date: 2007-08-04 01:26:22
Message-ID: 46B3D5BE.3010202@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches

Tom Lane wrote:
>
> There are two approaches we could take to fixing this:
>
> 1. Redirect_stderr is the start-time flag for both features, ie, if it's
> set we always create both pipes and start the syslogger, but
> Log_destination controls what actually gets used.  (Possibly
> Redirect_stderr should be renamed if we go this way.)
>
> 2. Invent a new PGC_POSTMASTER GUC variable that says whether to create
> the CSV pipe; then the syslogger process is started if either flag is
> set.
>
> #1 seems simpler but it might be too restrictive.  (In particular I'm
> not too sure what happens to the syslogger's own stderr.)
>
>   

I'm looking at doing #1, but I'm not sure where I can sensibly check 
that redirection is on if cvslog destination is specified. I could check 
when elog() is called, but that seems wasteful. Any ideas? I'd hate to 
have to fall back on making CSVlogging a PGC_POSTMASTER setting.

cheers

andrew


In response to

Responses

pgsql-hackers by date

Next:From: Rohit KhareDate: 2007-08-04 04:57:47
Subject: Re: .NET driver
Previous:From: Josh BerkusDate: 2007-08-03 23:36:15
Subject: Re: clog_buffers to 64 in 8.3?

pgsql-patches by date

Next:From: Hiroshi SaitoDate: 2007-08-04 14:47:33
Subject: Re: Correction of how to use TimeZone by ControlFile(xlog.c)
Previous:From: Decibel!Date: 2007-08-04 00:03:35
Subject: Re: Repair cosmetic damage (done by pg_indent?)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group