From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Oops in fe-auth.c |
Date: | 2007-07-23 16:59:19 |
Message-ID: | 46A4DE67.2020902@hagander.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Magnus Hagander wrote:
> On Mon, Jul 23, 2007 at 10:28:57AM -0400, Tom Lane wrote:
>>> Given this, I'll go ahead and fix fe-connect to support PQExpBuffers,
>>> unless there are any objections.
>> I'm not against that, but I question what bug you've really found.
>
> I never actually tested if it crashes on mingw, but looking some more at it
> it really should - once one of these errors happen.
Hm. Much easier than that - the code is new in HEAD. 8.2 did
fprintf(stderr). And HEAD still does that in at least one case.
Anyway, I'll go ahead with the patch I wrote since it does Seem Nicer to
actually use the PQexpbuffer code there, and the patch was rather
trivial, but it's certainly not something to backpatch then...
I also found at least one other place in libpq where it still does
fprintf(stderr). That should probably be fixed at the same time, right?
//Magnus
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2007-07-23 17:05:40 | Re: 8.2 is 30% better in pgbench than 8.3 |
Previous Message | Jim Nasby | 2007-07-23 16:52:21 | Re: 8.2 is 30% better in pgbench than 8.3 |
From | Date | Subject | |
---|---|---|---|
Next Message | Teodor Sigaev | 2007-07-23 17:12:29 | tsearch core path, v0.58 |
Previous Message | Andrew Dunstan | 2007-07-23 15:26:27 | Re: COPYable logs |