Skip site navigation (1) Skip section navigation (2)

Re: syslogger line-end processing infelicity

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: syslogger line-end processing infelicity
Date: 2007-06-03 08:51:03
Message-ID: 466280F7.1050002@hagander.net (view raw or flat)
Thread:
Lists: pgsql-hackers
Andrew Dunstan wrote:
> 
> 
> Magnus Hagander wrote:
>>> My second thought is that we should quite possibly abandon this
>>> translation altogether - we know that our COPY code is quite happy with
>>> either style of line ending, as long as the file is consistent, and also
>>> many Windows programs will quite happily read files with Unix style line
>>> endings (e.g. Wordpad, although not Notepad).
>>>     
>>
>> Agreed. We shouldn't touch the data. Every editor I know on windows
>> *except* notepad can deal just fine with Unix line endings, and if
>> you're logging your queries your logfile will be too large to work well
>> in notepad anyway :-)
>>
>>
>>
>>   
> 
> OK, so do we consider this a bug fix and backpatch it all the way to
> 8.0? Nobody's complained so far that I know of, and it's only damaged
> logs, not damaged primary data. I'm inclined just to fix it in HEAD, and
> release note the change in behaviour. It will matter more when we get
> machine-readable logs.

Agreed, I don't think we need to backpatch it. And if you do, you only
need to go as far as to 8.2, there are other bigger problems earlier
than that - the reason we're deprecating 8.0 and 8.1 (on win32 only!)
when 8.3 comes out. I guess if it applies with no changes you can
backpatch all the way (if at all), but don't put any extra work into it,
IMHO.

//Magnus

In response to

pgsql-hackers by date

Next:From: NikhilSDate: 2007-06-03 13:57:15
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support
Previous:From: Greg SmithDate: 2007-06-03 07:21:54
Subject: "Working with CVS" documentation

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group