Re: array type name mangling

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: array type name mangling
Date: 2007-05-05 15:08:10
Message-ID: 463C9DDA.8040502@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
>
> In connection with completing David Fetter's array of composites
> patch, I am looking at doing some better name mangling for array types
> as recently discussed. What I'm thinking of is prepending one or more
> underscores to the type name up to some limit (NAMEDATALEN / 2 ?) and
> if necessary truncating the result, and then looking to see if there
> is a name clash. That would, I hope, enable us to get rid of all the
> places where we require names to be no more than NAMEDATALEN - 2
> chars. Does that seem like a reasonable approach? Will it break
> anything, i.e., is there somewhere that has assumes the array type for
> foo will be called _foo rather than ___foo ?

Actually, looking back in the email history I see Tom suggested this,
which I'll try instead:

> prepend _, truncate to less than 64 bytes if necessary,
> then substitute numbers at the end if needed to get something unique.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-05-05 15:13:33 Re: array type name mangling
Previous Message Tom Lane 2007-05-05 15:03:37 Re: Integer datetimes