Re: Vista/IPv6

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Dave Page <dpage(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Vista/IPv6
Date: 2007-04-11 19:00:51
Message-ID: 461D3063.80108@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan wrote:
> Magnus Hagander wrote:
>>
>>> Anyway, the obvious fix seems to be to add a line to
>>> src/tools/msvc/Solution.pm to #define HAVE_IPV6 1 in pg_config.h
>>>
>>
>> Won't work, that hits both msvc and mingw. (assuming you maen
>> pg_config.h.win32, since pg_config.h is a generated file)
>>
>> The proper fix is to put it in the msvc build sys, where it writes
>> pg_config.h :-)
>
> Is that not what I suggested?

I thought you meant put it in the actual .h file that is used to
generate pg_config.h from. Apologies for my misunderstanding.

>> It also needs a new lib for initdb. I have a patch
>> for it, and it works here, I'm just asking if it's safe to enable it
>> or if
>> it may cause runtmie problems on platforms without ipv6.
>>
>>
>
> Which new lib? That seems odd since what we do on MinGW does work.

The winsock libs. Our mingw build links them explicitly to all binaries,
the msvc build only links it to the ones that actually need it. And with
ipv6 support, initdb suddenly needs it.

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2007-04-11 19:15:08 Re: So are we calling it: Feature Freeze?
Previous Message Andrew Dunstan 2007-04-11 18:36:25 Re: Vista/IPv6