Re: Fix for large file support

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Fix for large file support
Date: 2007-04-06 18:36:38
Message-ID: 46169336.50400@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
>> Andrew Dunstan wrote:

> Indeed, but that would be far more effectively addressed by fixing the
> *other* code path that doesn't segment at all (the
> LET_OS_MANAGE_FILESIZE option, which is most likely broken these days
> for lack of testing). I don't see the point of a halfway measure like
> increasing RELSEG_SIZE.

LET_OS_MANAGE_FILESIZE is good way. I think one problem of this option I
fixed. It is size of offset. I went thru the code and did not see any
other problem there. However, how you mentioned it need more testing. I
going to take server with large disk array and I will test it.

I would like to add --enable-largefile switch to configure file to
enable access to wide group of users. What you think about it?

Zdenek

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-04-06 18:45:46 Re: [PATCHES] Fix for large file support
Previous Message Andrew Dunstan 2007-04-06 18:27:15 Re: What X86/X64 OS's do we need coverage for?

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-04-06 18:45:46 Re: [PATCHES] Fix for large file support
Previous Message Joshua D. Drake 2007-04-06 17:12:59 Re: Auto Partitioning