Re: BUG #1736: endless loop in PQconnectdb

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Karsten Desler <kdesler(at)soohrt(dot)org>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #1736: endless loop in PQconnectdb
Date: 2005-07-03 15:57:21
Message-ID: 4594.1120406241@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Karsten Desler <kdesler(at)soohrt(dot)org> writes:
> * Bruce Momjian wrote:
>> I think what you are seeing is that the getaddrinfo memory is placed in
>> the PGconn structure that isn't freed until PQclear is called. Does
>> your test call PQclear()?

> s/PQclear/PQfinish/
> It does call PQclear on the result, and PQfinish on the connection.

In that case I think there is no doubt that you've found a bug in
getaddrinfo/freeaddrinfo, and you ought to be reporting it to your
libc provider. We do call freeaddrinfo on the result of getaddrinfo,
so if not everything is cleaned up, that's a library bug not ours.

You could check this by reducing the test case to getaddrinfo()
then freeaddrinfo() using the same parameters that fe-connect.c
passes.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Alvaro Herrera 2005-07-03 16:09:05 Re: BUG #1748: Unique contraints cannot be added to long text fields
Previous Message Karsten Desler 2005-07-03 08:58:15 Re: BUG #1736: endless loop in PQconnectdb