Re: pg_restore fails with a custom backup file

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Yoshiyuki Asaba <y-asaba(at)sraoss(dot)co(dot)jp>, z-saito(at)guitar(dot)ocn(dot)ne(dot)jp, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_restore fails with a custom backup file
Date: 2006-12-19 20:52:01
Message-ID: 458850F1.1050107@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander wrote:
> We need different macrosand possibly functions, yes.
> I think I got enough patched at home last night to get it working with
> this, I was just too focused on one set of macros at the time. It's not
> enough to include them very late - because off_t is used in the shared
> datastructures in pg_dump/etc. It is possible to localise it to the
> pg_dump binaries, though, given some header redirection *and* given that
> we change all those off_t to pgoff_t (or similar). I couldn't find a way
> to do it without changing the off_t define.
>
> I'll try to take a look at merging these two efforts (again unless
> beaten to it, have to do some of that dreaded christmas shopping as
> well...)
>
>
>

What is needed to test this? Just a custom dump file with a member >
2^31 bytes?

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2006-12-19 21:02:40 Re: pg_restore fails with a custom backup file
Previous Message Andrej Ricnik-Bay 2006-12-19 20:51:14 Re: Companies Contributing to Open Source