Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Phil Sorber <phil(at)omniti(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c
Date: 2011-10-12 23:07:22
Message-ID: 4588.1318460842@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Phil Sorber <phil(at)omniti(dot)com> writes:
> Then there is a separate section of code that is called as a separate
> function 'dumpUserConfig()' that does other role attributes like
> 'ALTER ROLE bob SET role TO charlie'. These are the ALTER's that can
> have dependencies on other roles.

Right. Phrased that way, this is an obvious improvement, and I concur
that it doesn't look like it could break anything that works now.
The more general problem remains to be solved, but we might as well
apply this.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2011-10-12 23:53:26 Re: Patch: Perl xsubpp
Previous Message Tom Lane 2011-10-12 22:44:55 Re: ALTER EXTENSION .. ADD/DROP weirdness