Re: Note about include files

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Note about include files
Date: 2000-10-02 14:45:03
Message-ID: 4558.970497903@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On a related note, does anyone know why the on_proc_exit and on_shmem_exit
> hooks use a second argument of type `caddr_t' rather than, say, void*,
> char*, Datum, ...? This artifact is the cause of about two thirds of the
> compile errors in the pedantic setting.

I was annoyed by that just the other day on an Alpha box (it provokes
lots of "integer cast to pointer of different size" warnings there).
I'm sure the use of caddr_t is strictly historical.

If you feel like doing something about it, changing the arguments of
these routines to be Datum and then adding the necessary
to-and-from-Datum macros seems like the obvious solution path.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2000-10-02 14:48:15 Re: libpq PGHOST
Previous Message Louis-David Mitterrand 2000-10-02 14:03:04 failed assertion error on PG-7.0.2