From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
---|---|
To: | Joachim Wieland <joe(at)mcknight(dot)de> |
Cc: | pgsql-patches(at)postgresql(dot)org, bruce(at)momjian(dot)us |
Subject: | Re: Allow commenting of variables in postgresql.conf to - |
Date: | 2006-07-27 14:24:43 |
Message-ID: | 44C8CCAB.8040100@sun.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Joachim,
I checked your improvement and fix some problem with following scenario:
shared_buffers = 3301
START
share_buffers = 333.39
HUP
share_buffers requires integer value. Skip configuration file
#share_buffers = 3301
HUP
.... silent - no message
I performed some cleanup in my code as well. I reduced some conditions,
which cannot occur and fixed context validation in the
set_config_options function. I hope that It is final version of our patch.
Thanks for cooperation
Zdenek
Attachment | Content-Type | Size |
---|---|---|
pg_conf_5.diff | text/x-patch | 39.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2006-07-27 14:50:47 | Re: [HACKERS] [COMMITTERS] pgsql: /contrib/cube improvements: |
Previous Message | Joshua Reich | 2006-07-27 14:21:59 | Re: [HACKERS] [COMMITTERS] pgsql: /contrib/cube improvements: Update |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2006-07-27 14:50:47 | Re: [HACKERS] [COMMITTERS] pgsql: /contrib/cube improvements: |
Previous Message | Joshua Reich | 2006-07-27 14:21:59 | Re: [HACKERS] [COMMITTERS] pgsql: /contrib/cube improvements: Update |