From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: tg_table_name and tg_table_schema for plpgsql |
Date: | 2006-05-28 01:17:29 |
Message-ID: | 4478FA29.3060701@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> Here's a patch for tg_table_name and tg_table_schema for plpgsql, which
>> I would appreciate a quick review of just to make sure I haven't missed
>> something or done something silly.
>>
>
> Looks all right other than odd indentation ;-)
>
Did you mean in pl_exec.c? It looks better when applied - but it's not
easy to fit that long call into 80 cols neatly. I guess if pg_indent
doesn't like it it will tidy thing up when we do a run.
> If you want to test tg_relid, what about casting it to regclass to get a
> reasonable symbolic printout?
>
>
Good idea - I'll do that for plpgsql where it's easier. I don't think
it's worth the trouble for the other PLs.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-05-28 03:25:23 | Re: [HACKERS] psql \copy warning |
Previous Message | Tom Lane | 2006-05-27 23:53:44 | Re: tg_table_name and tg_table_schema for plpgsql |