| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Christian Ullrich <chris(at)chrullrich(dot)net> |
| Cc: | michael(dot)paquier(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Sync tzload() and tzparse() APIs with IANA release tzcode2016c. |
| Date: | 2016-03-29 14:20:21 |
| Message-ID: | 444.1459261221@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Christian Ullrich <chris(at)chrullrich(dot)net> writes:
> * Tom Lane wrote:
>> But then, should not this code make sure that errno *always* gets set?
> A library function that does not fail does not touch errno.
Right, I meant "always in the error path".
>> I'd be inclined to think we should use _dosmaperr(), too, rather than
>> hand-coding it.
> Yes, of course. If only I had known about it ...
> New patch attached.
This looks good, will push shortly.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-03-29 14:40:13 | pgsql: Fix zic for Windows. |
| Previous Message | Christian Ullrich | 2016-03-29 14:11:42 | Re: [COMMITTERS] pgsql: Sync tzload() and tzparse() APIs with IANA release tzcode2016c. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2016-03-29 14:36:05 | Re: Updated backup APIs for non-exclusive backups |
| Previous Message | Ashutosh Bapat | 2016-03-29 14:20:15 | Re: Postgres_fdw join pushdown - INNER - FULL OUTER join combination generating wrong result |