David Fetter wrote:
>+ /* Disallow BADCHARS characters */
>+ if (strcspn(cstate->delim, BADCHARS) != 1)
>+ errmsg("COPY delimiter cannot be \"%#02x\"",
Is ERRCODE_FEATURE_NOT_SUPPORTED the right errcode? This isn't a
missing feature; we are performing a sanity check here. We can
reasonably expect never to support CR, LF or \ as the text delimiter.
Maybe ERRCODE_INVALID_PARAMETER_VALUE ? Or maybe we need a new one.
Also, I would probably make the format %#.02x so the result would look
like 0x0d (for a CR).
(I bet David never thought there would so much fuss over a handful of
lines of code)
In response to
pgsql-bugs by date
|Next:||From: Patrick Rotsaert||Date: 2006-01-30 14:50:06|
|Subject: BUG #2225: Backend crash -- BIG table|
|Previous:||From: Herv Hnoch||Date: 2006-01-30 10:47:10|
|Subject: BUG #2224: unlogical syntax error|
pgsql-patches by date
|Next:||From: Andrew Dunstan||Date: 2006-01-30 13:25:33|
|Subject: Re: Want to add to contrib.... xmldbx|
|Previous:||From: dueyduey||Date: 2006-01-30 10:33:35|
|Subject: BUG #2223: Misleading info in docs on volatility level of functions|