On Sun, Jan 29, 2006 at 10:20:47PM -0500, Neil Conway wrote:
> On Sun, 2006-01-29 at 17:03 -0800, David Fetter wrote:
> > Another followup, this time with the comment done right.
> 
> +       /* Disallow the forbidden_delimiter strings */
> +       if (strcspn(cstate->delim, BADCHARS) != 1)
> +               elog(ERROR, "COPY delimiter cannot be %#02x",
> +                        *cstate->delim);
> + 
> 
> The comment is still wrong: referencing "forbidden_delimiter" makes
> it sound like there is something named forbidden_delimiter, but
> there is not (at least in the patch as submitted).
> 
> The patch should also use ereport rather than elog, because this
> error message might reasonably be encountered by the user.

Patch with BADCHARS attached :)

Cheers,
D
-- 
David Fetter david(at)fetter(dot)org http://fetter.org/
phone: +1 415 235 3778

Remember to vote!

In response to

• Re: [PATCHES] BUG #2221: Bad delimiters allowed in COPY ... at 2006-01-30 03:20:47 from Neil Conway

Responses

• Re: [PATCHES] BUG #2221: Bad delimiters allowed in COPY ... at 2006-01-30 13:21:34 from Andrew Dunstan
• Re: [PATCHES] BUG #2221: Bad delimiters allowed in COPY ... at 2006-02-01 01:03:41 from Bruce Momjian

pgsql-bugs by date

Next:	From: dueyduey	Date: 2006-01-30 10:33:35
	Subject: BUG #2223: Misleading info in docs on volatility level of functions
Previous:	From: Michael Fuhr	Date: 2006-01-30 05:16:27
	Subject: Re: BUG #2217: serial in rule and trigger

pgsql-patches by date

Next:	From: Thomas Hallgren	Date: 2006-01-30 09:25:39
	Subject: Re: Want to add to contrib.... xmldbx
Previous:	From: Josh Berkus	Date: 2006-01-30 05:53:21
	Subject: Re: Want to add to contrib.... xmldbx