Re: pgsql: Index: src/pl/plpython/plpython.c

From: Neil Conway <neilc(at)samurai(dot)com>
To: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Index: src/pl/plpython/plpython.c
Date: 2005-12-29 21:54:55
Message-ID: 43B45B2F.50202@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Neil Conway wrote:
> Log Message:
> -----------
> Index: src/pl/plpython/plpython.c
> ===================================================================
[...]

*sigh*

Sorry for fat-fingering that: "cvs ci -F ~/the.patch" rather than "cvs
ci -F ~/commit_msg"

The commit message should have been:

In PLy_spi_execute_plan(), PL/Python invokes the type input function
for a Postgres datatype. The type input function might raise an
exception via elog, which will cause a Python reference leak (the
reference count a temporary Python object will not be decremented).
Therefore, enclose the call to the input function in a PG_TRY()
block and decrement the refcount on the object using PG_CATCH().

-Neil

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2005-12-29 23:29:31 committers email / archive problems
Previous Message Neil Conway 2005-12-29 21:47:49 pgsql: Index: src/pl/plpython/plpython.c