From: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
---|---|
To: | Dave Page <dpage(at)vale-housing(dot)co(dot)uk> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Jerry LeVan <jerry(dot)levan(at)eku(dot)edu> |
Subject: | Re: 1.4.1 On OSX |
Date: | 2005-12-21 13:12:21 |
Message-ID: | 43A954B5.6080203@pse-consulting.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Dave Page wrote:
> Hi Andreas,
>
> I finally tracked down the bug in 1.4.1 on Mac which causes a crash whenever
> pretty much any property dialogue is opened. Basically, in
> ctlComboBox::GetSelection() we call GetCurrentSelection(). In wxMac however,
> this simply calls GetSelection() which is a virtual and results in our
> GetSelection() actually getting called, in turn causing a loop and eventual
> stack overflow.
>
> So, the attached patch seems to fix the problem and return the auto-complete
> code to the same slightly-broken-but-usable state that it was in 1.4.0 (i.e,
> you can only type the first character of a data type for example, and the
> first match will be selected).
>
> Can you take a look and confirm my analysis (or call me an idiot, whatever
> is correct!) before I apply this to both branches and packare 1.4.1.plus
> please?
In general I agree. I committed a fix in ctlComboBoxFix doing
essentially the same, but the version dependent GetCurrentSelection code
isn't cluttered around the sources this way.
Regards,
Andreas
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2005-12-21 13:48:31 | Re: 1.4.1 On OSX |
Previous Message | svn | 2005-12-21 13:11:04 | SVN Commit by andreas: r4850 - trunk/pgadmin3/src/include/ctl |