| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Supporting NULL elements in arrays |
| Date: | 2005-11-14 10:09:56 |
| Message-ID: | 43786274.3020200@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On trying to recompile things, I find that contrib/intarray is broken
> by this change, because it's using the flags field for its own purposes:
>
> /*
> * flags for gist__int_ops, use ArrayType->flags
> * which is unused (see array.h)
> */
> #define LEAFKEY (1<<31)
> #define ISLEAFKEY(x) ( ((ArrayType*)(x))->flags & LEAFKEY )
>
> It seems likely that intarray is going to need some rather significant
> work anyway to deal with null elements, so this seems to me to be not
> necessarily a fatal objection. But why exactly does intarray need to
> play games with the contents of an array value?
Sorry, intarray was first our module for PgSQL. I'll remove usage of
ArrayType->flags soon.
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | eric.leguillier | 2005-11-14 10:29:10 | Running PostGre on DVD |
| Previous Message | Csaba Nagy | 2005-11-14 09:19:45 | Re: someone working to add merge? |