Re: findoidjoins

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: findoidjoins
Date: 2002-09-04 14:55:37
Message-ID: 4327.1031151337@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Joe Conway <mail(at)joeconway(dot)com> writes:
> I'm not sure I interpreted the intent of findoidjoins just right, but
> here it is updated for schemas, new reg* types, using SPI instead of
> libpgeasy, and returning the results as a table function. Any
> corrections/comments?

For what we want it for (viz, regenerating the oidjoins test every so
often), this is really a step backwards. It requires more work to run
than the original program, and it modifies the database under test,
which is undesirable because it's commonly run against template1.

I was thinking of keeping it as a client program, but recasting it to
use libpq since libpgeasy isn't in the standard distribution anymore.

I've looked through my notes and I can't find why I thought findoidjoins
was broken for 7.3. Did you come across anything obviously wrong with
its queries?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Tucker 2002-09-04 15:04:51 Re: possible vacuum improvement?
Previous Message Alvaro Herrera 2002-09-04 14:52:32 Re: HISTORY updated, 7.3 branded

Browse pgsql-patches by date

  From Date Subject
Next Message pgsql-bugs 2002-09-04 15:54:25 Bug #756: suggestion: file with password instead of $PGPASSWORD
Previous Message Dennis Björklund 2002-09-04 07:41:25 string not marked for translation