From: | Titus von Boxberg <ut(at)bhi-hamburg(dot)de> |
---|---|
To: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: PL/PGSQL: Dynamic Record Introspection |
Date: | 2005-07-14 22:26:43 |
Message-ID: | 42D6E6A3.3050108@bhi-hamburg.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Neil Conway schrieb:
> Titus von Boxberg wrote:
>
> Can you supply some proper regression tests, please? i.e. patch sql/plpgsql.sql and
expected/plpgsql.out in src/test/regress
In sql/plpgsql.sql I have added a function testing the new features
and altered expected/plpgsql.out
>
> A few minor comments from skimming the patch:
Done.
------------------
The modifications to the first one are the following:
- restored type evaluation in RECFIELD value evaluation
in exec_eval_datum to the previous semantics.
The addition should now be completely invisible to existing code.
- instead do a check in exec_eval_expr() if the expression
contains datums of the type record%variable. For these
the type cannot be stored in a plan because the type might change
between evaluations of this expr. --> free and reprepare the plan.
- storage allocated by exec_eval_expr() for the expression
record%FIELDNAMES (the array containing the names)
is freed in exec_eval_cleanup
------------------
regression tests are ok on my system.
Do you agree with the mods and the patch?
Regards
Titus
Attachment | Content-Type | Size |
---|---|---|
assocrec-current3.patch | text/plain | 24.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alon Goldshuv | 2005-07-15 00:22:18 | Re: COPY FROM performance improvements |
Previous Message | Titus von Boxberg | 2005-07-14 22:04:25 | Re: PL/PGSQL: Dynamic Record Introspection |