Re: [PATCHES] HEAD doesn't cope with libraries in non-default

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "Jim C(dot) Nasby" <decibel(at)decibel(dot)org>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] HEAD doesn't cope with libraries in non-default
Date: 2005-07-12 21:06:27
Message-ID: 42D430D3.5090401@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Could we please get this patch applied? It seems like the right thing to do.

cheers

andrew

Jim C. Nasby wrote:

>On Tue, Jul 05, 2005 at 10:09:19PM +0200, Peter Eisentraut wrote:
>
>
>>I wrote:
>>
>>
>>>So either we code up some intelligence to put the "C" in the right
>>>position or we have to pass down "A B" and "D" separately from the
>>>main makefile.
>>>
>>>
>>The following patch might just do the former. Please try it out.
>>
>>
>>diff -ur ../cvs-pgsql/src/Makefile.shlib ./src/Makefile.shlib
>>--- ../cvs-pgsql/src/Makefile.shlib 2005-07-04 16:32:57.000000000 +0200
>>+++ ./src/Makefile.shlib 2005-07-05 22:02:10.556162778 +0200
>>@@ -240,7 +240,7 @@
>> SHLIB_LINK += -ltermcap -lstdc++.r4 -lbind -lsocket -L/boot/develop/lib/x86
>> endif
>>
>>-SHLIB_LINK := $(filter -L%, $(LDFLAGS)) $(SHLIB_LINK)
>>+SHLIB_LINK := $(filter -L%, $(SHLIB_LINK)) $(filter -L%, $(LDFLAGS)) $(filter-out -L%, $(SHLIB_LINK))
>> ifeq ($(enable_rpath), yes)
>> SHLIB_LINK += $(rpath)
>> endif
>>
>>
>
>Worked on platypus:
>http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=platypus&dt=2005-07-05%2022:03:35
>
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message xavier.marquis 2005-07-12 21:27:29 SQLException: Cannot be less than zero
Previous Message Hannu Krosing 2005-07-12 21:03:22 Re: CONCURRENT INDEXing again (was: Must be owner to

Browse pgsql-patches by date

  From Date Subject
Next Message xavier.marquis 2005-07-12 21:27:29 SQLException: Cannot be less than zero
Previous Message David Fetter 2005-07-12 21:01:36 Re: PL/Perl list value return causes segfault