| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Pavel Stehule <stehule(at)kix(dot)fsv(dot)cvut(dot)cz>, pgsql-patches(at)postgresql(dot)org, pgman(at)candle(dot)pha(dot)pa(dot)us |
| Subject: | Re: final light versions of Oracle compatibility (SQLSTATE, |
| Date: | 2005-06-10 01:31:49 |
| Message-ID: | 42A8ED85.5020100@samurai.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Tom Lane wrote:
> I still find the grammar changes to be an ugly kluge --- it should be
> possible to do this without introducing bogus nonterminals.
The scope-local variables need to be added to the namespace by the time
that we parse the WHEN clauses. I can see two ways to do that: adding a
bogus non-terminal, or using a mid-rule action. Mid-rule actions are
pretty ugly, though. Is there a better alternative?
> The ns push/pop operations don't appear to be correctly matched
Sorry, asleep at the switch -- the ns_push/pop stuff isn't even needed,
it was from an early revision of the patch.
A revised patch is attached -- once the nonterminal stuff is sorted I'll
apply it.
-Neil
| Attachment | Content-Type | Size |
|---|---|---|
| sqlstate-7.patch | text/x-patch | 17.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-06-10 03:02:36 | Re: [HACKERS] PGPASSWORD and client tools |
| Previous Message | Bruce Momjian | 2005-06-10 01:19:46 | Re: plperl features |