Re: updated GiST patch

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: updated GiST patch
Date: 2005-05-17 02:09:46
Message-ID: 4289526A.5020706@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Patch applied.

Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
>>BTW, this idiom occurs a few times:
>
>
>> if (BufferIsValid(buf))
>> {
>> ReleaseBuffer(buf);
>> buf = InvalidBuffer;
>> }
>
>
> I'd leave it as-is; ISTM to be more easily understandable than the
> alternatives you suggest.

Yeah, fair enough.

-Neil

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-05-17 02:36:14 Re: GiST header cleanup
Previous Message Neil Conway 2005-05-17 02:07:46 GiST header cleanup