Re: [PATCHES] plperl and pltcl installcheck targets

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] plperl and pltcl installcheck targets
Date: 2005-05-11 17:16:34
Message-ID: 42823DF2.2070108@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

[redirected to -hackers]

Tom Lane wrote:

>Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>
>>Is it worth rearranging things for plpython so that it follows the same
>>test layout as the other 2 (i.e. a test subdir with all the test files
>>and a script called runtest that does the work)? Especially if we bring
>>in other PLs as has been discussed, some standard might be useful.
>>
>>
>
>Actually, we have a standard: it's pg_regress. The right thing for
>someone to do is migrate all these tests into the form already used
>for the main backend and all of contrib.
>
>I think this would require a small addition to the pg_regress script
>to make it configurable as to which PL to install, instead of always
>installing plpgsql, but that seems like a reasonable thing to do.
>
>
>
>

I'm not sure why it would matter having it there. I would just make the
first test to load the language in question - pretty much this, right?

CREATE FUNCTION "plperl_call_handler" () RETURNS language_handler AS
'$libdir/plperl' LANGUAGE C;
CREATE TRUSTED LANGUAGE "plperl" HANDLER "plperl_call_handler";
CREATE LANGUAGE "plperlu" HANDLER "plperl_call_handler";

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2005-05-11 17:41:08 Re: Views, views, views: Summary of Arguments
Previous Message Robert Treat 2005-05-11 17:05:13 7.3.10 working

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-05-11 17:58:01 Re: [BUGS] BUG #1588: pg_autovacuum sleep parameter overflow
Previous Message Bruce Momjian 2005-05-11 16:12:54 Re: update some urls