| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | pgman(at)candle(dot)pha(dot)pa(dot)us |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: CSV multiline final fix |
| Date: | 2005-02-22 04:55:44 |
| Message-ID: | 421ABB50.6090006@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Andrew Dunstan wrote:
>Bruce Momjian said:
>
>
>>Shame we had to duplicate CopyReadLine() in a sense.
>>
>>
>>
>>
>
>
>If you can find a clean way to merge them please do - I'll be very grateful.
> My head started to spin when I tried. In general I dislike having more than
>2 or 2 levels of logic in a given piece of code.
>
>
>
>
Previous comment courtesy clumsy fingers and the Department of
Redundancy Department (of course, I meant 2 or 3).
Anyway, please review this patch for copy.c - it's possibly more to your
taste. It's less redundant, but I'm not sure it's more clear.
cheers
andrew
| Attachment | Content-Type | Size |
|---|---|---|
| copy-multiline2.patch | text/x-patch | 11.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-02-22 04:58:47 | Re: CSV multiline final fix |
| Previous Message | Bruce Momjian | 2005-02-22 04:43:35 | pgsql: Use _() macro consistently rather than gettext(). |